Bump net.sourceforge.pmd:pmd-java from 7.26.0 to 7.27.0

core/src/main/java/org/apache/cxf/common/jaxb/JAXBUtils.java

@@ -249,7 +249,7 @@ public static Class<?> holderClass(String type) {
      * @return true if the word is a keyword.
      * @see org.apache.cxf.helpers.JavaUtils
      */
-    protected static boolean isJavaKeyword(String word) {
+    private static boolean isJavaKeyword(String word) {
         return JavaUtils.isJavaKeyword(word);
     }
 

core/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java

@@ -86,7 +86,7 @@ public String run() {
     }
 
 
-    @SuppressWarnings("PMD.UselessPureMethodCall")
+    @SuppressWarnings("PMD.UnusedReturnValue")
     public static void doHacks() {
         if (skipHack("org.apache.cxf.JDKBugHacks.all")) {
             return;

core/src/main/java/org/apache/cxf/common/logging/LogUtils.java

@@ -226,8 +226,8 @@ public static Logger getL7dLogger(Class<?> cls,
     /**
      * Create a logger
      */
-    @SuppressWarnings("PMD.UselessPureMethodCall")
-    protected static Logger createLogger(Class<?> cls,
+    @SuppressWarnings("PMD.UnusedReturnValue")
+    private static Logger createLogger(Class<?> cls,
                                          String name,
                                          String loggerName) {
         ClassLoader orig = getContextClassLoader();

core/src/main/java/org/apache/cxf/configuration/jsse/SSLUtils.java

@@ -192,7 +192,7 @@ public static KeyManager[] loadKeyStore(KeyManagerFactory kmf,
         return keystoreManagers;
     }
 
-    protected static byte[] loadFile(String fileName) throws IOException {
+    private static byte[] loadFile(String fileName) throws IOException {
         if (fileName == null) {
             return null;
         }

core/src/main/java/org/apache/cxf/staxutils/transform/TransformUtils.java

@@ -116,7 +116,7 @@ public static XMLStreamReader createTransformReaderIfNeeded(XMLStreamReader read
         return reader;
     }
 
-    protected static void convertToQNamesMap(Map<String, String> map,
+    static void convertToQNamesMap(Map<String, String> map,
                                              QNamesMap elementsMap,
                                              Map<String, String> nsMap) {
         if (map != null) {
@@ -163,7 +163,7 @@ static void convertToMapOfElementProperties(Map<String, String> map,
         }
     }
 
-    protected static void convertToSetOfQNames(List<String> set,
+    static void convertToSetOfQNames(List<String> set,
                                                Set<QName> elementsSet) {
         if (set != null) {
             for (String entry : set) {

core/src/main/java/org/apache/cxf/ws/addressing/VersionTransformer.java

@@ -60,6 +60,7 @@
  * version of WS-Adressing (for example WS-RM depends on the
  * 2004/08 version).
  */
+@SuppressWarnings("PMD.InstantiableUtilityClass")
 public class VersionTransformer {
 
     protected static final String NATIVE_VERSION = Names.WSA_NAMESPACE_NAME;

core/src/test/java/org/apache/cxf/attachment/AttachmentDeserializerTest.java

@@ -367,6 +367,7 @@ public void testDeserializerWithCachedFile() throws Exception {
 
 
     @Test
+    @SuppressWarnings("PMD.UnusedReturnValue")
     public void testSmallStream() throws Exception {
         byte[] messageBytes = ("------=_Part_1\n\nJJJJ\n------=_Part_1\n\n"
             + "Content-Transfer-Encoding: binary\n\n=3D=3D=3D\n------=_Part_1\n").getBytes();

core/src/test/java/org/apache/cxf/resource/URIResolverTest.java

@@ -48,6 +48,7 @@ public class URIResolverTest {
     private Throwable checkingThreadThrowable;      // assumes single-thread test execution
 
     @Test
+    @SuppressWarnings("PMD.UnusedReturnValue")
     public void testJARProtocol() throws Exception {
         uriResolver = new URIResolver();
 

integration/jca/src/test/java/org/apache/cxf/jca/core/classloader/PlugInClassLoaderTest.java

@@ -38,7 +38,7 @@
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
-
+@SuppressWarnings("PMD.UnusedReturnValue")
 public class PlugInClassLoaderTest {
     private static final Logger LOG = LogUtils.getLogger(PlugInClassLoaderTest.class);
     private static boolean debug;

integration/spring-boot/autoconfigure/src/main/java/org/apache/cxf/spring/boot/autoconfigure/jaxws/CxfJaxwsAutoConfiguration.java

@@ -33,6 +33,7 @@
 
 @Configuration
 @ConditionalOnClass({ Resource.class, WebServiceContext.class })
+@SuppressWarnings("PMD.InstantiableUtilityClass")
 public class CxfJaxwsAutoConfiguration {
     @Bean
     static BeanFactoryPostProcessor jaxwsBeanFactoryPostProcessor() {

integration/spring-boot/autoconfigure/src/test/java/org/apache/cxf/spring/boot/autoconfigure/micrometer/provider/SpringBasedTimedAnnotationProviderTest.java

@@ -54,7 +54,7 @@ public class SpringBasedTimedAnnotationProviderTest {
     private MethodDispatcher methodDispatcher;
 
     @Before
-    @SuppressWarnings("PMD.UselessPureMethodCall")
+    @SuppressWarnings("PMD.UnusedReturnValue")
     public void setUp() {
         openMocks(this);
         underTest = new SpringBasedTimedAnnotationProvider();

maven-plugins/codegen-plugin/src/main/java/org/apache/cxf/maven_plugin/wsdl2java/WsdlOptionLoader.java

@@ -121,7 +121,7 @@ private static String[] readOptionsFromFile(File dir, String wsdlName) throws Mo
         }
     }
 
-    protected static WsdlOption generateWsdlOptionFromFile(final File wsdl,
+    private static WsdlOption generateWsdlOptionFromFile(final File wsdl,
                                                            File defaultOutputDir)
         throws MojoExecutionException {
 

maven-plugins/wadl2java-plugin/src/main/java/org/apache/cxf/maven_plugin/wadlto/OptionLoader.java

@@ -138,7 +138,7 @@ private static List<File> getWadlFiles(File dir, String[] includes, String[] exc
     }
 
 
-    protected static WadlOption generateWadlOptionFromFile(final File wadl,
+    private static WadlOption generateWadlOptionFromFile(final File wadl,
                                                            final Option defaultOptions,
                                                            File defaultOutputDir)
         throws MojoExecutionException {

parent/pom.xml

@@ -437,12 +437,12 @@
                         <dependency>
                             <groupId>net.sourceforge.pmd</groupId>
                             <artifactId>pmd-core</artifactId>
-                            <version>7.26.0</version>
+                            <version>7.27.0</version>
                         </dependency>
                         <dependency>
                             <groupId>net.sourceforge.pmd</groupId>
                             <artifactId>pmd-java</artifactId>
-                            <version>7.26.0</version>
+                            <version>7.27.0</version>
                         </dependency>
                     </dependencies>
                     <configuration>

rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/types/CorbaObjectReferenceEventProducer.java

@@ -135,7 +135,7 @@ public List<Attribute> getAttributes() {
         return refAttrs;
     }
 
-    protected EprMetaData getObjectReferenceBinding(Definition wsdlDef, QName bindingName) {
+    private EprMetaData getObjectReferenceBinding(Definition wsdlDef, QName bindingName) {
         EprMetaData info = new EprMetaData();
         Binding wsdlBinding = wsdlDef.getBinding(bindingName);
 

rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/JAXBContextInitializer.java

@@ -83,7 +83,7 @@ class JAXBContextInitializer extends ServiceModelVisitor {
     }
 
     @Override
-    @SuppressWarnings("PMD.UselessPureMethodCall")
+    @SuppressWarnings("PMD.UnusedReturnValue")
     public void begin(MessagePartInfo part) {
         Class<?> clazz = part.getTypeClass();
         if (clazz == null) {

rt/databinding/jaxb/src/test/java/org/apache/cxf/jaxb/JAXBDataBindingTest.java

@@ -304,7 +304,7 @@ public void testResursiveType() throws Exception {
         assertEquals(2, classes.size());
     }
 
-    public abstract static class Type2 extends AddressEntity<Type2> { //NOPMD
+    public abstract static class Type2 extends AddressEntity<Type2> {
     }
 
     public abstract static class AddressEntity<T extends AddressEntity<T>> {

rt/features/logging/src/main/java/org/apache/cxf/ext/logging/event/LogMessageFormatter.java

@@ -55,11 +55,11 @@ public static String format(LogEvent event) {
         }
         return b.toString();
     }
-    protected static String localPart(QName name) {
+    private static String localPart(QName name) {
         return name == null ? null : name.getLocalPart();
     }
 
-    protected static void write(StringBuilder b, String key, String value) {
+    private static void write(StringBuilder b, String key, String value) {
         if (value != null) {
             b.append("    ").append(key).append(": ").append(value).append('\n');
         }

rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultExceptionClassProviderTest.java

@@ -34,7 +34,7 @@
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.MockitoAnnotations.openMocks;
 
-@SuppressWarnings("PMD.UselessPureMethodCall")
+@SuppressWarnings("PMD.UnusedReturnValue")
 public class DefaultExceptionClassProviderTest {
 
     private static final Exception EXCEPTION_CAUSE = new CauseException();

rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/DefaultTimedAnnotationProviderTest.java

@@ -42,7 +42,7 @@
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.MockitoAnnotations.openMocks;
 
-@SuppressWarnings({"unused", "PMD.UselessPureMethodCall"})
+@SuppressWarnings({"unused", "PMD.UnusedReturnValue"})
 public class DefaultTimedAnnotationProviderTest {
 
     private DefaultTimedAnnotationProvider underTest;

rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/StandardTagsTest.java

@@ -37,7 +37,7 @@
 import static org.mockito.MockitoAnnotations.openMocks;
 
 
-@SuppressWarnings("PMD.UselessPureMethodCall")
+@SuppressWarnings("PMD.UnusedReturnValue")
 public class StandardTagsTest {
 
     private static final String DUMMY_METHOD_NAME = "dummyMethod";

rt/features/metrics/src/test/java/org/apache/cxf/metrics/micrometer/provider/jaxws/JaxwsFaultCodeProviderTest.java

@@ -35,7 +35,7 @@
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.MockitoAnnotations.openMocks;
 
-@SuppressWarnings("PMD.UselessPureMethodCall")
+@SuppressWarnings("PMD.UnusedReturnValue")
 public class JaxwsFaultCodeProviderTest {
 
     private static final String RUNTIME_FAULT_STRING = "RUNTIME_FAULT";

rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/ResponseImpl.java

@@ -553,11 +553,11 @@ private void reportMessageHandlerProblem(String name, Class<?> cls, MediaType ct
         throw new ResponseProcessingException(this, errorMessage, cause);
     }
 
-    protected void autoClose(Class<?> cls, boolean exception) {
+    void autoClose(Class<?> cls, boolean exception) {
         autoCloseWithHint(cls, false, exception);
     }
 
-    protected void autoCloseWithHint(Class<?> cls, boolean autoCloseHint, boolean exception) {
+    void autoCloseWithHint(Class<?> cls, boolean autoCloseHint, boolean exception) {
         if (!entityBufferred && !JAXRSUtils.isStreamingOutType(cls)
             && (exception || MessageUtils.getContextualBoolean(outMessage,
                 RESPONSE_STREAM_AUTO_CLOSE, autoCloseHint))) {

rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/provider/ServerProviderFactory.java

@@ -281,7 +281,7 @@ protected void setProviders(boolean custom, boolean busGlobal, Object... provide
             containerResponseFilters.values());
     }
 
-    protected void injectApplicationIntoFeature(Feature feature) {
+    private void injectApplicationIntoFeature(Feature feature) {
         if (application != null) {
             AbstractResourceInfo info = new AbstractResourceInfo(feature.getClass(),
                                                                  ClassHelper.getRealClass(feature),
@@ -451,7 +451,7 @@ private FeatureContext createServerFeatureContext() {
         return featureContext;
     }
 
-    protected static boolean isPrematching(Class<?> filterCls) {
+    private static boolean isPrematching(Class<?> filterCls) {
         return AnnotationUtils.getClassAnnotation(filterCls, PreMatching.class) != null;
     }
 

rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/EndpointReferenceTest.java

@@ -326,7 +326,7 @@ public void testProviderGetPort() throws Exception {
     }
 
     final class MyEndpointReference extends EndpointReference {
-        protected MyEndpointReference() {
+        MyEndpointReference() {
         }
 
         public void writeTo(Result result) {

rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/spi/WrapperClassLoaderTest.java

@@ -140,7 +140,7 @@ public void testWrapperClassLoaderWithWrappedOperationsAndLegacyConvention() thr
                 loadedClassNames);
     }
 
-    @SuppressWarnings("PMD.UselessPureMethodCall")
+    @SuppressWarnings("PMD.UnusedReturnValue")
     private List<String> testWrapperClassLoaderWithNamingConvention(WrapperClassNamingConvention convention)
             throws Exception {
         bus.setExtension(convention, WrapperClassNamingConvention.class);

rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/WebClient.java

@@ -1201,7 +1201,7 @@ protected Response handleResponse(Message outMessage, Class<?> responseClass, Ty
         }
     }
 
-
+    @SuppressWarnings("PMD.ProtectedMemberInFinalClass")
     private final class BodyWriter extends AbstractBodyWriter {
 
         protected void doWriteBody(Message outMessage,

rt/rs/client/src/test/java/org/apache/cxf/jaxrs/client/JAXRSClientFactoryBeanTest.java

@@ -321,7 +321,7 @@ protected void initializeProvider(InterceptorProvider provider, Bus bus) {
             provider.getOutInterceptors().add(testInterceptor);
         }
 
-        protected boolean isInitialized() {
+        private boolean isInitialized() {
             return testInterceptor.isInitialized();
         }
     }

rt/rs/description-common-openapi/src/main/java/org/apache/cxf/jaxrs/common/openapi/DefaultApplicationFactory.java

@@ -33,7 +33,7 @@
 import org.apache.cxf.jaxrs.provider.ServerProviderFactory;
 
 public final class DefaultApplicationFactory {
-    protected static class DefaultApplication extends Application {
+    static class DefaultApplication extends Application {
         private final Set<Class<?>> serviceClasses;
 
         DefaultApplication(final Set<Class<?>> serviceClasses) {

rt/security/src/main/java/org/apache/cxf/rt/security/SecurityConstants.java

@@ -36,6 +36,7 @@
  * More specific configuration tags for WS-SecurityPolicy are configured in the SecurityConstants
  * class in the cxf-rt-ws-security module, which extends this class.
  */
+@SuppressWarnings("PMD.InstantiableUtilityClass")
 public class SecurityConstants {
 
     //

rt/security/src/main/java/org/apache/cxf/rt/security/rs/RSSecurityConstants.java

@@ -23,6 +23,7 @@
  * Some common security constants that can be used RS-Security (for now they are used in the
  * JOSE + HTTP Signature modules).
  */
+@SuppressWarnings("PMD.InstantiableUtilityClass")
 public class RSSecurityConstants {
 
     /**

rt/transports/http/src/test/java/org/apache/cxf/transport/http/spring/HttpConduitConfigurationTest.java

@@ -116,6 +116,8 @@ private void verifyConduit(HTTPConduit conduit) {
 
 
     public static final class ManagersFactory {
+        private ManagersFactory() {
+        }
 
         public static KeyManager[] getKeyManagers() {
             KeyManagersType kmt = new KeyManagersType();

rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/util/PollingMessageListenerContainer.java

@@ -107,7 +107,7 @@ public void run() {
             }
         }
 
-        protected void safeRollBack(Session session) {
+        void safeRollBack(Session session) {
             try {
                 if (session != null && session.getTransacted()) {
                     session.rollback();

rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/AbstractJMSTester.java

@@ -252,6 +252,7 @@ protected static Message createMessage(String correlationId) {
         return outMessage;
     }
 
+    @SuppressWarnings("PMD.UnusedReturnValue")
     protected static void verifyReceivedMessage(Message message) {
         String response = "<not found>";
         InputStream bis = message.getContent(InputStream.class);

rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalConduit.java

@@ -64,7 +64,8 @@ public void close() throws IOException {
         protected void onFirstWrite() throws IOException {
             dispatchToService(false);
         }
-        protected void dispatchToService(boolean empty) throws IOException {
+
+        void dispatchToService(boolean empty) throws IOException {
             final MessageImpl inMsg = new MessageImpl();
             transportFactory.copy(message, inMsg);
 

rt/transports/local/src/main/java/org/apache/cxf/transport/local/LocalDestination.java

@@ -97,7 +97,7 @@ protected void onFirstWrite() throws IOException {
                 dispatchToClient(false);
             }
 
-            protected void dispatchToClient(boolean empty) throws IOException {
+            void dispatchToClient(boolean empty) throws IOException {
                 final MessageImpl m = new MessageImpl();
                 localDestinationFactory.copy(message, m);
                 if (!empty) {

rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10AImpl.java

@@ -54,6 +54,7 @@
  * WS-ReliableMessaging 1.0 encoding and decoding. This converts between the standard WS-RM objects and the
  * 1.0 representation using the WS-Addressing recommendation 200508 namespace.
  */
+@SuppressWarnings("PMD.ProtectedMemberInFinalClass")
 public final class EncoderDecoder10AImpl extends EncoderDecoder {
 
     public static final EncoderDecoder10AImpl INSTANCE = new EncoderDecoder10AImpl();

rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder10Impl.java

@@ -54,6 +54,7 @@
  * WS-ReliableMessaging 1.0 encoding and decoding. This converts between the standard WS-RM objects and the
  * 1.0 representation using the WS-Addressing 200408 namespace specified in the WS-RM 1.0 recommendation.
  */
+@SuppressWarnings("PMD.ProtectedMemberInFinalClass")
 public final class EncoderDecoder10Impl extends EncoderDecoder {
 
     public static final EncoderDecoder10Impl INSTANCE = new EncoderDecoder10Impl();

rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/EncoderDecoder11Impl.java

@@ -56,6 +56,7 @@
  * WS-ReliableMessaging 1.1/1.2 encoding and decoding. This just works with the standard internal form of the
  * WS-RM data structures.
  */
+@SuppressWarnings("PMD.ProtectedMemberInFinalClass")
 public final class EncoderDecoder11Impl extends EncoderDecoder {
 
     public static final EncoderDecoder11Impl INSTANCE = new EncoderDecoder11Impl();

rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/RMContextUtils.java

@@ -26,7 +26,7 @@
 /**
  * Holder for utility methods relating to contexts.
  */
-
+@SuppressWarnings({ "PMD.InstantiableUtilityClass", "PMD.ProtectedMemberInFinalClass" })
 public final class RMContextUtils {
 
     /**

rt/ws/rm/src/test/java/org/apache/cxf/ws/rm/AbstractRMInterceptorTest.java

@@ -48,7 +48,7 @@
 /**
  *
  */
-@SuppressWarnings("PMD.UselessPureMethodCall")
+@SuppressWarnings("PMD.UnusedReturnValue")
 public class AbstractRMInterceptorTest {
     @Test
     public void testAccessors() {