[POC] feat!: drop cordova-serve#164
Draft
erisu wants to merge 3 commits into
Draft
Conversation
* Dropped `cordova-serve` dependency from `cordova-browser`
* Re-implement with bare minimum requirements.
* Added npm packages `express` and `compression` for serving content content
* Added npm package `open` for automatic opening of browser support
* Only browser that `open` support will be supported.
The following browsers are supported: brave, chrome, edge, firefox, safari.
This does not include release variations, e.g. Chrome canary, Firefox Developer Edition, etc.
* `--target=none` can be passed to disable automatic opening of the browser.
* Added npm package `string-dedent` (`String.dedent` TC39 proposal)
* Other repos used `dedent` but this package is created by the champions for the `String.dedent` TC39 proposal.
* Added/updated printout notice:
* Serving is a development, for testing only, feature.
* Recommend app developers to use their own setup for advance debugging features.
* Added HTTPS/SSL Support (User must supply key & cert via run args)
* `--ssl-key-file=/path/to/key`
* `--ssl-cert-file=/path/to/cert`
erisu
force-pushed
the
feat/drop-cordova-serve
branch
from
July 16, 2026 06:45
fb92ce2 to
8604bb8
Compare
dpogue
reviewed
Jul 16, 2026
Co-authored-by: Darryl Pogue <darryl@dpogue.ca>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 69.39% 68.87% -0.53%
==========================================
Files 8 8
Lines 1049 1057 +8
==========================================
Hits 728 728
- Misses 321 329 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Consolidate
cordova-servefunctionality incordova-browserDescription
cordova-servedependency fromcordova-browserexpressandcompressionfor serving content contentopenfor automatic opening of browser supportopensupport will be supported. The following browsers are supported: brave, chrome, edge, firefox, safari. This does not include release variations, e.g. Chrome canary, Firefox Developer Edition, etc.openpackage.--target=nonecan be passed to disable automatic opening of the browser and the app developer can manually open the browser of choice.string-dedent(String.dedentTC39 proposal)dedentbut I believe the above package is preferred as it was created by one of the champions for theString.dedentTC39 proposal.--ssl-key-file=/path/to/key--ssl-cert-file=/path/to/certTODO:
Testing
Build app and use
cordova run browsercommand.Checklist
(platform)if this change only applies to one platform (e.g.(android))