Skip to content

reset last-returned element in EnumerationIterator.remove - #729

Open
rootvector2 wants to merge 1 commit into
apache:masterfrom
rootvector2:enumeration-iterator-remove-reset-last
Open

reset last-returned element in EnumerationIterator.remove#729
rootvector2 wants to merge 1 commit into
apache:masterfrom
rootvector2:enumeration-iterator-remove-reset-last

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

remove() never nulls last, so a second call without an intervening next() deletes another element equal to the last returned one from the backing collection instead of throwing IllegalStateException; found sweeping the package's remove() methods, where the sibling adapters (EntrySetMapIterator, ZippingIterator, IteratorChain) already clear their last-returned field.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

remove() removed by value but never cleared last, so a repeat call without next() deleted a second equal element instead of throwing IllegalStateException.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant