[COLLECTIONS-898] AbstractSetTest cannot be used with an explicitly typed Set (unless it's based on String) - #727
Merged
garydgregory merged 1 commit intoAug 25, 2026
Conversation
Member
|
Jira ticket is COLLECTIONS-898. |
Member
Author
|
Hmm, indeed sorry about that bad copy/paste. Fixed. |
…yped Set (unless it's based on String) * pick a valid element from getFullElements() instead of adding an hardcoded String
tmortagne
force-pushed
the
COLLECTIONS-898-typed-AbstractSetTest
branch
from
August 19, 2026 13:03
284e123 to
5ab3ea7
Compare
garydgregory
added a commit
that referenced
this pull request
Aug 25, 2026
typed Set (unless it's based on String) (#727).
Member
|
@tmortagne Thank you, merged 🚀 |
Member
Author
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick a valid element from getFullElements(), instead of adding a hardcoded String.
I did not dare making more changes to the logic of that test, but I'm honestly not sure there is that much value in the
"Empty set shouldn't equal nonempty set"bit, compared to the"Sets with different contents shouldn't be equal"one at the end. I mean it's not really the point of this test to validate the#addvs#addAllAPIs behaviors.There does not seem to already exist a test class designed specifically to validate
AbstractSetTestbehavior (but there are various test classes which rely onAbstractSetTest), so I did not create a new one for such a small change. But I may have missed it.Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.