Reject UTF-16 surrogate values in Character converter - #438
Merged
garydgregory merged 1 commit intoAug 12, 2026
Conversation
Member
|
Closing; duplicate of #436 , same question. |
Contributor
Author
|
fair enough on the dup. to answer the question here too: you never type the raw character, the converter parses the literal six ascii chars |
Member
|
Reopening: I see your point, thank you for replying. Reviewing again. |
garydgregory
added a commit
that referenced
this pull request
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Character converter in
putDefaultMapaccepts\uD800through\uDFFFbecauseCharacter.isBmpCodePointonly checks whether the value fits in 16 bits, not whether it is a valid Unicode scalar value; surrogates are reserved for UTF-16 encoding pairs and casting one to char produces an isolated surrogate that corrupts downstream UTF-8 encoding or text normalization.mvn; that'smvnon the command line by itself.