CAMEL-24651: Fix NPE in ExceptionHelper.stackTraceToString() when exception is null - #26221
Merged
davsclaus merged 1 commit intoSep 9, 2026
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
✅ Generated files are up to dateAn earlier CI run reported uncommitted generated changes; the latest run no longer does. |
davsclaus
approved these changes
Sep 9, 2026
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 564 tested, 27 compile-only — current: 564 all testedMaveniverse Scalpel detected 591 affected modules (current approach: 564).
|
| Module | Duration | Status |
|---|---|---|
| Camel :: Support | 17.0s | SUCCESS |
| Camel :: Core | n/a |
Top 20 slowest modules:
Camel :: Support(17.0s)
apupier
previously requested changes
Sep 9, 2026
davsclaus
force-pushed
the
fix/CAMEL-24651-exception-stacktrace-npe
branch
from
September 9, 2026 09:00
63c760d to
1cefa0b
Compare
apupier
reviewed
Sep 9, 2026
apupier
left a comment
apupier
left a comment
Contributor
There was a problem hiding this comment.
there is a useless comment but not a blocker for the merge
…eption is null
When ${exception.stacktrace} is evaluated on an exchange that has no
exception, LanguageHelper.exceptionStacktrace() calls
ExceptionHelper.stackTraceToString(null), which then NPEs on
e.printStackTrace(printWriter).
Add a null guard in ExceptionHelper.stackTraceToString() so that it
returns null when the supplied Throwable is null, consistent with the
existing behaviour of LanguageHelper.exceptionMessage().
gnodet
force-pushed
the
fix/CAMEL-24651-exception-stacktrace-npe
branch
from
September 9, 2026 13:26
1cefa0b to
8da1a4e
Compare
davsclaus
added
port/camel-4.22.x
Contributor
Author
🔄 Backport BotThis bugfix was merged into
Labels Port PRs will be created shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CAMEL-24651: regression introduced by commit f9048eb ("consolidate duplicated code for printing the stack traces").
Problem
When
${exception.stacktrace}is evaluated on an exchange that has no exception:LanguageHelper.exceptionStacktrace()callsexception(exchange)which returnsnullnullis passed toExceptionHelper.stackTraceToString(null)stackTraceToString()callse.printStackTrace(printWriter)→ NPEPrior to the refactoring, the call site had an explicit null check that was lost during consolidation.
LanguageHelper.exceptionMessage()still has its null guard and is unaffected.Fix
Add a null guard at the top of
ExceptionHelper.stackTraceToString()so it returnsnullwhen the suppliedThrowableisnull. This is the defensive approach: it protects all callers rather than just the one inLanguageHelper.Test
Added
SimpleTest#testExceptionStacktraceNoExceptionto cover the regression: evaluating${exception.stacktrace}on an exchange with no exception must returnnull(not throw NPE).