-
Notifications
You must be signed in to change notification settings - Fork 5.2k
CAMEL-24649: Add unmatched request handler to REST OpenAPI component #26203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ullgren
wants to merge
6
commits into
apache:main
Choose a base branch
from
ullgren:CAMEL-24649-add-unmatched-request-handler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0467923
CAMEL-24649: Add unmatched request handler to REST OpenAPI component
ullgren beac47c
Fix for unmatchedRequestHandler assignment issue
ullgren 2b21b62
Documenting the factory finder route to register handler
ullgren 34001d0
Add test to cover factory finder
ullgren 472d469
Clarify precedence of handlers in docs
ullgren 62c25f0
Remove payload before response in default handler
ullgren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...va/org/apache/camel/component/rest/openapi/DefaultRestOpenApiUnmatchedRequestHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.camel.component.rest.openapi; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.apache.camel.Exchange; | ||
|
|
||
| /** | ||
| * Default {@link RestOpenApiUnmatchedRequestHandler} that returns empty body with the HTTP status code and, if | ||
| * provided, the {@code Allow} header. The payload in the incoming request message is removed. | ||
| * | ||
| * @since 4.23 | ||
| */ | ||
| public class DefaultRestOpenApiUnmatchedRequestHandler implements RestOpenApiUnmatchedRequestHandler { | ||
|
|
||
| @Override | ||
| public void handle(Exchange exchange, int statusCode, List<String> allowedMethods) { | ||
| exchange.getMessage().setBody(null); | ||
| exchange.getMessage().setHeader(Exchange.HTTP_RESPONSE_CODE, statusCode); | ||
| if (!allowedMethods.isEmpty()) { | ||
| exchange.getMessage().setHeader("Allow", String.join(", ", allowedMethods)); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...main/java/org/apache/camel/component/rest/openapi/RestOpenApiUnmatchedRequestHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.camel.component.rest.openapi; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.apache.camel.Exchange; | ||
|
|
||
| /** | ||
| * Used for customizing the HTTP 404 and 405 responses when an incoming request does not match any operation defined in | ||
| * the OpenAPI specification. | ||
| * <p> | ||
| * This allows to plugin different handlers to produce custom error response bodies. | ||
| * | ||
| * @see DefaultRestOpenApiUnmatchedRequestHandler | ||
| * @since 4.23 | ||
| */ | ||
| public interface RestOpenApiUnmatchedRequestHandler { | ||
|
|
||
| String FACTORY = "rest-openapi-unmatched-request-handler-factory"; | ||
|
ullgren marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Handles the incoming request that did not match any operation in the OpenAPI specification. | ||
| * | ||
| * @param exchange the current exchange | ||
| * @param statusCode the HTTP status code (404 or 405) | ||
| * @param allowedMethods the list of allowed HTTP methods for the requested path (empty for 404) | ||
| */ | ||
| void handle(Exchange exchange, int statusCode, List<String> allowedMethods); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.