Skip to content

GH-51228: [Python] Raise instead of crashing on an invalid registry #51247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1fanwang wants to merge 4 commits into
base: main
Choose a base branch
from
+29 −0
Open

GH-51228: [Python] Raise instead of crashing on an invalid registry #51247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
968a198
GH-51228: [Python] Reject invalid tabular function registry
1fanwang Sep 8, 2026
2824914
GH-51228: Mark the subprocess test with pytest.mark.processes
1fanwang Sep 8, 2026
ff7a7b2
GH-51228: Assert the type error with pytest.raises
1fanwang Sep 10, 2026
388ac7b
GH-51228: [Python] Reject invalid UDF registration registries
1fanwang Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/pyarrow/_compute.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3482,6 +3482,8 @@ def _register_user_defined_function(register_func, func, function_name, function

if func_registry is None:
c_func_registry = NULL
elif not isinstance(func_registry, FunctionRegistry):
raise TypeError("func_registry must be a FunctionRegistry")
else:
c_func_registry = (<FunctionRegistry>func_registry).registry

Expand Down Expand Up @@ -3516,6 +3518,8 @@ def call_tabular_function(function_name, args=None, func_registry=None):
c_func_name = tobytes(function_name)
if func_registry is None:
c_func_registry = NULL
elif not isinstance(func_registry, FunctionRegistry):
raise TypeError("func_registry must be a FunctionRegistry")
else:
c_func_registry = (<FunctionRegistry>func_registry).registry
if args is None:
Expand Down
25 changes: 25 additions & 0 deletions python/pyarrow/tests/test_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,31 @@ def test_list_functions():
assert "add" in pc.list_functions()


def test_call_tabular_function_rejects_invalid_registry():
Comment thread
1fanwang marked this conversation as resolved.
with pytest.raises(TypeError,
match="func_registry must be a FunctionRegistry"):
pc.call_tabular_function("", None, 1)


@pytest.mark.parametrize("register_function", [
pc.register_scalar_function,
pc.register_vector_function,
pc.register_aggregate_function,
pc.register_tabular_function,
])
def test_register_function_rejects_invalid_registry(register_function):
with pytest.raises(TypeError,
match="func_registry must be a FunctionRegistry"):
register_function(
func=lambda context: None,
function_name="invalid_registry",
function_doc={"summary": "", "description": ""},
in_types={},
out_type=pa.struct([]),
func_registry=1,
)


def _check_get_function(name, expected_func_cls, expected_ker_cls,
min_num_kernels=1):
func = pc.get_function(name)
Expand Down
Loading