Skip to content

GH-51232: [CI] Update comment bot to prevent people being assigned things via "take" unless unassigned - #51233

Open
thisisnic wants to merge 2 commits into
apache:mainfrom
thisisnic:GH-51232-fix-take
Open

GH-51232: [CI] Update comment bot to prevent people being assigned things via "take" unless unassigned#51233
thisisnic wants to merge 2 commits into
apache:mainfrom
thisisnic:GH-51232-fix-take

Conversation

@thisisnic

@thisisnic thisisnic commented Sep 8, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Non-committers could assign themselves issues already assigned to people

What changes are included in this PR?

Only let "take" assign issues if the issue isn't assigned

Are these changes tested?

No

Are there any user-facing changes?

No

Copilot AI lite review requested due to automatic review settings September 8, 2026 10:19
@thisisnic
thisisnic requested a review from raulcd as a code owner September 8, 2026 10:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow still runs on PR comments (issue_comment applies to PRs too), so take can unintentionally assign pull requests unless the job is additionally gated to issues-only.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Arrow’s GitHub comment bot (“take”) behavior and contributor docs so that self-assignment only occurs when an issue is currently unassigned, preventing accidental reassignment of already-owned issues.

Changes:

  • Restrict the comment_bot.yml “Assign issue” job to run only when the issue has no assignee.
  • Update developer documentation to clarify that take only works on unassigned issues.
File summaries
File Description
docs/source/developers/bug_reports.rst Clarifies that take only self-assigns unassigned issues.
CONTRIBUTING.md Updates contributor guidance to match the new take behavior.
.github/workflows/comment_bot.yml Adds an “unassigned only” guard to the take-based assignment job.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/comment_bot.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 8, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow condition change directly addresses the reported issue and the accompanying documentation updates are consistent with the new behavior.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants