GH-51210: [C++] Initialize output_ on empty select_k inputs - #51212
Open
taepper wants to merge 1 commit into
Open
GH-51210: [C++] Initialize output_ on empty select_k inputs#51212taepper wants to merge 1 commit into
output_ on empty select_k inputs#51212taepper wants to merge 1 commit into
Conversation
taepper
force-pushed
the
select-k-unset-datum
branch
from
September 7, 2026 13:17
1be8398 to
0cbf916
Compare
pitrou
approved these changes
Sep 7, 2026
pitrou
added
Critical Fix
github-actions
Bot
added
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This fixes possible crashes of
SelectKUnstableif inputs were emptyWhat changes are included in this PR?
This includes the bug fix and test cases which cover the broken prior behavior.
Are these changes tested?
Yes.
Are there any user-facing changes?
This PR contains a "Critical Fix".:
(c) a bug that causes a crash
If
SelectKUnstableis called on an empty table or chunked-array the process terminates with the exceptionstd::bad_variant_access.Through python, the wrapping of the (invalid) Datum in a python object already fails with the following error message:
SelectKUnstablecan crash on empty inputs #51210