GH-49952: [C++][Gandiva] Use timegm in date_time_test utilities#49953
Open
Reranko05 wants to merge 1 commit intoapache:mainfrom
Open
GH-49952: [C++][Gandiva] Use timegm in date_time_test utilities#49953Reranko05 wants to merge 1 commit intoapache:mainfrom
Reranko05 wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As discussed in PR #49887, the Gandiva datetime test utilities currently use
mktime(), which interprets timestamps as local time and can behave differently across platforms and DST boundaries.This PR switches the test utilities to
timegm()so timestamps are interpreted consistently as UTC. This also removes the existing workaround logic inEpoch()that was previously needed formktime()behavior on Windows/MSVC.What changes are included in this PR?
mktime()withtimegm()indate_time_test.cc_mkgmtimeEpoch()Are these changes tested?
DateTimeTestProjector.TestFromUtcTimestamprepeatedly locallygandiva-projector-testsuite successfullyAre there any user-facing changes?
No.
Github Issue: #49952