GH-47447: [C++] Fix replace_with_mask for null type arrays#49950
Open
AnkitAhlawat7742 wants to merge 1 commit intoapache:mainfrom
Open
GH-47447: [C++] Fix replace_with_mask for null type arrays#49950AnkitAhlawat7742 wants to merge 1 commit intoapache:mainfrom
AnkitAhlawat7742 wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #47447
Rationale for this change
replace_with_mask crashes when called with null type arrays because a code path incorrectly returns Status::OK() from a function with return type Result<int64_t>.
This PR fixes the issue by ensuring the function returns a valid int64_t value instead of Status::OK() for successful executon
What changes are included in this PR?
Are these changes tested?
Yes, manually run the test case
Are there any user-facing changes?
No
This PR contains a "Critical Fix".
This change fixes a crash in replace_with_mask when operating on null type arrays. The crash occurs due to an invalid successful return path internally constructing Result with Status::OK().
replace_with_maskcrashes when null type inputs are used #47447