fix: don't panic on ArrayData::try_new on bad input even when force_validate feature is on#10282
Open
rluvaton wants to merge 4 commits into
Open
Conversation
force_validate feature is on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
the caller of
try_newis responsible for handling errors, so it should not panic even whenforce_validatefeature is on.the added benefit is that validation is not called twice on
try_newwhenforce_validatefeature is onWhat changes are included in this PR?
use builder validation call
Are these changes tested?
yes
Are there any user-facing changes?
error instead of panic
Found while testing:
MapArraywith nullable key field #10272