fix(parquet): guard byte-stream-split encoder release against never-flushed buffer - #1273
Open
tom-eon wants to merge 1 commit into
Open
fix(parquet): guard byte-stream-split encoder release against never-flushed buffer#1273tom-eon wants to merge 1 commit into
tom-eon wants to merge 1 commit into
Conversation
…lushed buffer Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tom-eon
force-pushed
the
fix-byte-stream-split-release-nil
branch
from
September 1, 2026 14:49
843c38a to
7135617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
byteStreamSplitEncoder.Releaseunconditionally passesenc.flushBuffertoreleaseBufferToPool, which dereferences it. The flush buffer is allocated lazily on the firstFlushValues, so releasing an encoder that never flushed — whichcolumnWriter.Closedoes for a column chunk that received no values — dereferences nil and crashes the process with a SIGSEGV.ByteStreamSplitFixedLenByteArrayEncoder.Releasehas the same defect.What changes are included in this PR?
A nil guard at the top of
releaseBufferToPool, covering both encoders, plus a regression test that releases a never-flushed BYTE_STREAM_SPLIT encoder for all five physical types (INT32, INT64, FLOAT, DOUBLE, FIXED_LEN_BYTE_ARRAY).Are these changes tested?
Yes. The new test panics on every subtest without the fix and passes with it; the existing
parquet/internal/encodingandparquet/filesuites pass.Are there any user-facing changes?
No API changes. Writing a parquet file with a BYTE_STREAM_SPLIT column no longer panics when a column chunk ends up empty (e.g. an empty trailing row group).