perf(parquet/pqarrow): write binary values from Arrow offsets - #1262
Open
fallintoplace wants to merge 2 commits into
Open
perf(parquet/pqarrow): write binary values from Arrow offsets#1262fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
zeroshade
approved these changes
Aug 31, 2026
Member
|
Just needs to fix the linting issue |
fallintoplace
force-pushed
the
perf/parquet-pqarrow-binary-offsets
branch
from
August 31, 2026 20:49
672ea23 to
657d17c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[]parquet.ByteArrayallocation from non-dictionary writes.Benchmark
64K String rows, uncompressed, dictionary disabled, Apple M1 Pro. Median of 3 runs with 3 seconds per run.
Benchmark command:
go test ./parquet/pqarrow -run '^$' -bench '^BenchmarkWriteArrowBinaryOffsets$' -benchmem -benchtime=3s -count=3Tests
go test ./parquet/...go vet ./parquet/internal/encoding ./parquet/metadata ./parquet/file ./parquet/pqarrow