perf(parquet): reuse boolean Bloom filter hashes - #1258
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
false([]byte{0}) andtrue([]byte{1}).Hasherimplementations on the existing path.This removes a
Sum64call for every boolean while keeping the same hash values.Benchmark
Apple M1 Pro, Go 1.26.3, 7 samples, one CPU:
go test -vet=off ./parquet/metadata -run '^$' -bench '^BenchmarkBloomFilter(HashingFromBitmap|BooleanBitmap)' -benchmem -benchtime=150ms -count=7 -cpu=1The benchmark matrix covers 100K and 1M booleans, all false, all true, alternating, random, and spaced values with 10% and 50% nulls.
Median results for alternating values:
For alternating data, hashing is 3.5x to 4.8x faster and insertion is about 1.9x faster.
Tests
go test ./parquet/metadataPARQUET_TEST_DATA="$PWD/parquet-testing/data" go test ./...go vet ./parquet/metadata