Aries-2233 Unify duplicate implementations#139
Open
amichair wants to merge 9 commits into
Open
Conversation
alien11689
reviewed
Jun 7, 2026
| @@ -40,38 +41,22 @@ | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
Contributor
There was a problem hiding this comment.
do we still have to suppress the warning in this class?
Contributor
Author
There was a problem hiding this comment.
there are some unrelated classes with this annotation as well, removed all of them in separate commit.
| /** | ||
| * A collection of utilities that can be useful to SPI implementations. | ||
| */ | ||
| public class Utils { |
Contributor
There was a problem hiding this comment.
I am not a big fan of the utility classes that can be bag for everything. I would recommend renaming this class to CollectionUtils and renaming the method getChangedProps to be more collection oriented e.g. getChangedKeys
added 8 commits
June 8, 2026 02:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.