test(elasticsearch-logger): drop the max_pending_entries metadata after the discard test - #13924
Merged
Merged
Conversation
…er the discard test TEST 1 of t/plugin/elasticsearch-logger2.t sets plugin metadata max_pending_entries = 1 and leaves it in etcd for the rest of the file. Since apache#13826 the batch processor discards a new entry while one is still pending, so TEST 8 loses its second log entry whenever the first bulk request to Elasticsearch is still in flight, which is always the case when ES has to create the index first. Delete the metadata at the end of TEST 1, as t/plugin/elasticsearch-logger.t already does.
nic-6443
approved these changes
Sep 9, 2026
|
Note: Because of the flakiness, seems like #13651 is blocked by this PR. Please let me know once this is merged, so we can complete my PR. 🙂 |
juzhiyuan
approved these changes
Sep 14, 2026
bzp2010
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
t/plugin/elasticsearch-logger2.tTEST 8 is flaky in CI. It fails on master and on unrelated PRs since 2026-08-20 (for example this run on master and this one on #13651), and often survives the automatic rerun.TEST 1 sets plugin metadata
max_pending_entries = 1and never removes it, so etcd keeps it for the rest of the file. Since #13826 the batch processor discards a new entry while one is still pending. In TEST 8 the second request's entry is therefore discarded whenever the first bulk request to Elasticsearch is still in flight, which is always the case when ES has to create the index first (fresh ES in CI). The test then never logsservices-second-*.This PR deletes the metadata at the end of TEST 1, the way
t/plugin/elasticsearch-logger.talready does, so the later blocks run with the default limit. Verified locally with a fresh index before every run: 0/3 pass before, 3/3 after.Checklist