feat: Add excludeResourceType config to prevent ADC from deleting API managed resources - #2794
Open
luarx wants to merge 3 commits into
Open
feat: Add excludeResourceType config to prevent ADC from deleting API managed resources#2794luarx wants to merge 3 commits into
luarx wants to merge 3 commits into
Conversation
Author
|
Friendly ping on this 👋 Has anyone had a chance to review it yet? 🙏 I'd really appreciate any feedback @nic-6443 @shreemaan-abhishek @AlinsRan, if one of you has some time, I'd love to get this moving as it is blocking us and maybe you know any other solution 😇 Btw, I am the same one that opened this unrelated merged PR too :) |
…-managed resources Introduces a new `provider.exclude_resource_type` config field (e.g. `[Consumer, ConsumerGroup]`) that is threaded through ProviderConfig → provider.Options → adcclient.New → Client.Sync(), so periodic ADC reconciliation sweeps skip resources of those types that were created via API rather than CRD — preventing the controller from deleting them.
luarx
force-pushed
the
feat/exclude-resource-type-config
branch
from
July 24, 2026 10:12
bcf0c5c to
b1f7d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Introduces a new
provider.exclude_resource_typeconfig field (e.g.[Consumer, ConsumerGroup]) that is threaded through ProviderConfig → provider.Options → adcclient.New → Client.Sync(), so periodic ADC reconciliation sweeps skip resources of those types that were created via API rather than CRD — preventing the controller from deleting them.Implements this issue: #2795
▎--> And will enable this PR to be merged if accepted apache/apisix-helm-chart#983
Pre-submission checklist:
▎ Backward compatible: Yes — exclude_resource_type defaults to []/unset. Options.ApplyToList only overrides ExcludeResourceType when len(o.ExcludeResourceType) > 0, so existing configs behave exactly as before.