Skip to content

2.4.x#69

Open
supertick wants to merge 8 commits into
apache:2.4.xfrom
supertick:2.4.x
Open

2.4.x#69
supertick wants to merge 8 commits into
apache:2.4.xfrom
supertick:2.4.x

Conversation

@supertick

Copy link
Copy Markdown

No description provided.

@twogee

twogee commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

Could you please provide a unit test to demonstrate what is wrong with IVY-1576 fix?

@twogee

twogee commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

I suggest closing this PR. The main problem here is that programmatic use should not be adressed by adding CLI options which make no sense. Also, if resolve() ends with errors, it's best to throw an exception encapsulating whatever relevant information is available, rather than blithely carrying on.

@supertick

Copy link
Copy Markdown
Author

I think it would be great "not" to have an additional CLI option, but then you cannot have a System.exit(1) terminating the client code (https://github.com/apache/ant-ivy/blob/2.4.x/src/java/org/apache/ivy/Main.java#L313) just because of an error.

The errors (and the successes) can be queried out of the ResolveReport. A client can programmatically make decisions based on the data returned. And the run() methods still throw their respective exceptions which could be caught by the client consumer.

The new option is to alleviate the problematic design of having an error terminate a client consumer with a System.exit.

Perhaps a design would be to copy/paste Main.java to IvyClient.java and remove the System.exit - but then it would be less normalized, which has its own flaws.

@wordlessly

Copy link
Copy Markdown

I also spam this pull request. (why not open issue tracker here?)

Ivy CLI says: -types comma separated list of accepted artifact types

java -jar ivy-2.4.0.jar -cache ./ivy -types source,jar ...

does NOT work. What does work is a white space separated list of artifacts.

@twogee

twogee commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

Issue tracker for the project is JIRA. Apache has own Git infrastructure, GitHub is used to increase exposure and as easy means to suggest code changes (rather than uploading patches).

Please check the latest Ivy build. I cannot verify your report right now, but the value of types should be split correctly in master.

@twogee

twogee commented Apr 12, 2018

Copy link
Copy Markdown
Contributor

@supertick FYI, Ivy 2.5.0 RC is on the way, @nlalevee has kindly taken the role of release manager. Your latest commits are not merged to master, though. If you are interested in using 2.5.0, please let us know.

@sutchark

Copy link
Copy Markdown

How should we let you know? Here?

I am interested in using 2.5.0.

@twogee

twogee commented Apr 12, 2018

Copy link
Copy Markdown
Contributor

Check out the nightlies
I was commenting here because @supertick is apparently pushing changes to 2.4.x release branch, but the RC is from the master.

@bodewig

bodewig commented Feb 16, 2026

Copy link
Copy Markdown
Member

can anybody explain what this PR is about? The title doesn't say so.

2.4.x is a dead end, there won't be any new 2.4.x releases.

@twogee

twogee commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

AFAICR, this is an attempt to backport stuff to 2.4.x branch (which for some reasons is considered superior; I believe that might be related to SBT using their own fork). Hope @eric-milles improvements may be useful for resolving the schism ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants