[AMORO-4368][Dashboard] Fix Tables menu navigation after viewing Hive tables - #4369
Open
csurong wants to merge 1 commit into
Open
[AMORO-4368][Dashboard] Fix Tables menu navigation after viewing Hive tables#4369csurong wants to merge 1 commit into
csurong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Clicking Tables after viewing a plain Hive table restores its cached identifier under
/tables. This calls the generic details endpoint and reports that the table does not exist, although/hive/detailsloads it successfully.Closes #4368.
Brief change log
Make the Tables sidebar entry return to
/tableswithout table query parameters. Selecting a table still opens the appropriate details page, and the table tree continues to restore its expanded nodes from session storage.How was this patch tested?
pnpm exec eslint src/components/Sidebar.vuepnpm buildgit diff --checkDocumentation