Skip to content

[AMORO-1523][AMS] Auto-install discovered plugins when no plugin configs exist #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhang-arvin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AMORO-1523][AMS] Auto-install discovered plugins when no plugin configs exist #4347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions amoro-ams/src/main/java/org/apache/amoro/server/manager/AbstractPluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,19 @@ public void initialize() {
foundAvailablePlugins();

List<PluginConfiguration> pluginConfigs = loadPluginConfigurations();
// If no plugin configs were loaded from file but plugins were found via ServiceLoader,
// create default configurations so they can be installed. This handles the case where
// AMS is started from an IDE without the full plugins directory structure.
if (pluginConfigs.isEmpty() && !foundedPlugins.isEmpty()) {
pluginConfigs =
foundedPlugins.keySet().stream()
.map(PluginConfiguration::emptyConfig)
.collect(Collectors.toList());
LOG.info(
"No {} plugin configurations found, auto-installing discovered plugins: {}",
pluginCategory(),
foundedPlugins.keySet());
}
pluginConfigs.stream()
.sorted(Comparator.comparing(PluginConfiguration::getPriority))
.forEach(
Expand Down
Loading