Skip to content

[#2436] Fix SizeStatisticImpl.addSize on isEnabled like CountStatisticImpl #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrpav merged 1 commit into from
Aug 10, 2026
+19 −11
Merged

[#2436] Fix SizeStatisticImpl.addSize on isEnabled like CountStatisticImpl #2437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions activemq-client/src/main/java/org/apache/activemq/management/SizeStatisticImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,18 +52,26 @@ public synchronized long getCount() {
return count;
}

public synchronized void addSize(long size) {
count++;
totalSize += size;
if (size > maxSize) {
maxSize = size;
public void addSize(long size) {
// Same enabled gate as CountStatisticImpl.increment(): skip the monitor
// (and parent propagation) entirely when statistics are disabled —
// enabled is a volatile read, so the disabled fast path is contention-free.
if (!isEnabled()) {
return;
}
if (size < minSize || minSize == 0) {
minSize = size;
}
updateSampleTime();
if (parent != null) {
parent.addSize(size);
synchronized (this) {
count++;
totalSize += size;
if (size > maxSize) {
maxSize = size;
}
if (size < minSize || minSize == 0) {
minSize = size;
}
updateSampleTime();
if (parent != null) {
parent.addSize(size);
}
}
}

Expand Down
Loading