Fix tile row col reversal to align with OGC standards and remove dead code - #325
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns the OGC API Tiles “visual map tile” route with standard OGC row/column semantics (tileRow=y, tileCol=x) and removes unused vector-tile/MVT plumbing that no longer has a consumer.
Changes:
- Swaps row/column handling for DAS visual tiles to match OGC semantics and updates tests accordingly.
- Removes dead vector-tile (Elasticsearch MVT) code paths and related mapper/interface methods.
- Updates the products listing URL template placeholders to use
{tileRow}/{tileCol}.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/test/java/au/org/aodn/ogcapi/server/tile/RestApiTest.java | Updates/strengthens tests for visual tile forwarding semantics; updates vector-tile route test to expect NOT_IMPLEMENTED. |
| server/src/main/java/au/org/aodn/ogcapi/server/tile/RestService.java | Removes dead getVectorTileOfCollection implementation and related imports. |
| server/src/main/java/au/org/aodn/ogcapi/server/tile/RestExtApi.java | Updates visual_tile_url_template placeholders to {tileRow}/{tileCol} and documents the intended semantics. |
| server/src/main/java/au/org/aodn/ogcapi/server/tile/RestApi.java | Switches DAS visual tile forwarding to pass x before y (tileCol before tileRow); removes vector-tile route implementation. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/Search.java | Removes the unused searchCollectionVectorTile method from the Search interface. |
| server/src/main/java/au/org/aodn/ogcapi/server/core/service/ElasticSearch.java | Removes the Elasticsearch MVT implementation and unused config field(s). |
| server/src/main/java/au/org/aodn/ogcapi/server/core/mapper/BinaryResponseToBytes.java | Deletes unused mapper that supported the removed vector-tile flow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| String encodedVariable = URLEncoder.encode(variablePart, StandardCharsets.UTF_8); | ||
|
|
||
| if (canVisual) { | ||
| // Placeholders are named after the OGC path variables themselves (tileRow/tileCol, row=y col=x), not {x}/{y} |
Comment on lines
105
to
+109
| getBasePath() + "/tiles/WebMercatorQuad/2/0/1?collections=b299cdcd-3dee-48aa-abdd-e0fcdbb9cadc", | ||
| byte[].class | ||
| ); | ||
|
|
||
| // No meaningful verify can be done here, we keep it here so that we know that test case considered. | ||
| Assertions.assertEquals(HttpStatus.NOT_IMPLEMENTED, tiles.getStatusCode()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverse tileRow tileCol to OGC standard
Delete dead code