Conversation
Audited every claim in the 2.0.0 entry against the tree at the 1.29.0 and 2.0.0 tags instead of against the draft it grew from. Four entries did not belong to the release: - Voice Family settings module. The module is in the tree at 1.29.0 (51 files including its route file, factory, filter and both locale files) and is the headline item of the 1.29.0 release notes. 2.0.0 only fixed its VoiceBindingsList provide, which stays listed under Fixed. - mainFileInternal asset filter. Added by #253 on 11 March, three months before the 1.29.0 tag. Internal-image support is older still (1.26.0). - Public export create binding to a licences array. #256 is the commit the 1.29.0 tag points at, so it shipped there. - "vue-router 4 to 5" is wrong: 1.29.0 already ran ^5.0.2 and 2.0.0 runs ^5.2.0, which the dependency list in the same file stated correctly. The breaking change is the file-based routing, not a major bump. Both #84735 references leave 2.0.0 with the first and third item; that work item belongs entirely to 1.29.0. The mainFileInternal filter was never documented in any release, so it is added to the 1.29.0 entry where it actually shipped.
…gelog doc: correct the 2.0.0 changelog against the tags (#85491)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only, no code and no new version.
Four claims in the 2.0.0 entry were verified against the tags and did not belong to that release —
the Voice Family module, the
mainFileInternalfilter and the public-export licences array allshipped in 1.29.0, and "vue-router 4 → 5" was never a major bump. The
mainFileInternalfilter isadded to the 1.29.0 entry, which is where it actually shipped.
Contains #268.