(anycable-go: v0.7.1) Remove default resource limits to fix partial override issues#55
Open
dumitraand wants to merge 1 commit into
Open
(anycable-go: v0.7.1) Remove default resource limits to fix partial override issues#55dumitraand wants to merge 1 commit into
dumitraand wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When users set partial resource overrides like:
Helm deep-merges these with the chart defaults, resulting in:
This causes Kubernetes validation errors:
requests.cpu (1000m)>limits.cpu (350m)(spec.template.spec.containers[0].resources.requests: Invalid value: "1": must be less than or equal to cpu limit of 350m)Proposed Solution
Remove default resource values so users have full control. This is a common pattern for Helm charts to avoid unexpected merge behavior.