Skip to content

(anycable-go: v0.7.1) Remove default resource limits to fix partial override issues#55

Open
dumitraand wants to merge 1 commit into
anycable:masterfrom
dumitraand:ad/comment-resources
Open

(anycable-go: v0.7.1) Remove default resource limits to fix partial override issues#55
dumitraand wants to merge 1 commit into
anycable:masterfrom
dumitraand:ad/comment-resources

Conversation

@dumitraand

Copy link
Copy Markdown

Summary

  • Remove default resources values to prevent Helm deep-merge issues when users partially override resource requests/limits
  • Bump chart version to 0.7.1

Problem

When users set partial resource overrides like:

resources:
  requests:
    cpu: 1
    memory: 2G
  limits:
    memory: 2G

Helm deep-merges these with the chart defaults, resulting in:

resources:
  requests:
    cpu: 1        # 1000m from user
    memory: 2G
  limits:
    cpu: 350m     # from defaults (not overridden)
    memory: 2G

This causes Kubernetes validation errors: requests.cpu (1000m) > limits.cpu (350m) (spec.template.spec.containers[0].resources.requests: Invalid value: "1": must be less than or equal to cpu limit of 350m)

Proposed Solution

Remove default resource values so users have full control. This is a common pattern for Helm charts to avoid unexpected merge behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant