Set [[accuracyMode]] when constructing a GeolocationPosition - #1
Open
marcoscaceres wants to merge 1 commit into
Open
Set [[accuracyMode]] when constructing a GeolocationPosition#1marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to w3c#233. The construction of a new
GeolocationPositionis now passed a fourth argument and there is a new[[accuracyMode]]internal slot, but the construction algorithm did not accept the argument or set the slot, and the emulated-position branch passed only three arguments, so[[accuracyMode]]was never set. This adds anAccuracyModeparameter to the construction algorithm, sets[[accuracyMode]]from it, and passes it from the emulated-position branch. Found while prototyping w3c#233 in WebKit.