Repository navigation
Phones: the tab bar avatar opens Settings directly - #29
Merged
Merged
Conversation
On phones (≤ 720px, the iPhone PWA) the avatar in the floating tab bar is now a link to /settings instead of an account menu (Edit profile / Settings / Pair new device + streak line): all three items lead into Settings anyway. Desktop and iPad keep the top-bar avatar's menu. The link keeps the account label (with the daily-goal progress) and gets aria-current on /settings, where the pill rests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On phones (≤ 720px, the iPhone PWA) tapping the avatar in the floating tab bar now goes straight to Settings. The account menu is gone there (Edit profile / Settings / Pair new device + the streak line). All three items led into Settings anyway.
AppNav.svelte: the tab bar's avatar is a link to/settings. It keeps the account label with the daily-goal progress as its accessible name, getsaria-current="page"on/settings(where the sliding pill already rests) and the press scale.Tests
mobile.spec.ts(@mobile-only, iPhone): the avatar is a link (no button left in the tab bar), it opens Settings with no menu, and it isaria-currentthere.profile.spec.ts/streak.spec.ts@mobile: the avatar is found as a button or a link. The account menu is only checked above 720px.bun run check0/0,lint,test(471) green; e2emobile profile streak i18non desktop + iPhone + iPad: 32 passed.Screenshots (iPhone, 390×844)
🤖 Generated with Claude Code