Repository navigation
Fix main CI: long menus stay inside the viewport; two e2e races - #28
Merged
Merged
Conversation
The Overdue card pushes Home's lists down, so the quest picker's menu (position: fixed, no height cap) could run past the bottom of the viewport. Its lower items were then only reachable by scrolling the page, which moves the trigger and the menu with it, so they could never be clicked. Menu now caps itself at the room on its side, opens on the side with more room and scrolls inside. e2e: the time-block test waits for the edit sheet's exit animation before clicking the block again (the click landed on the closing modal in main's CI run); the hideDone test closes the quest filter before clicking the eye it can cover when many quests exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's CI after #27 failed in
home.spec.ts(time blocks). Investigating it surfaced a real UI bug plus two test races.Menu ran past the viewport (UI bug)
The new Overdue card pushes Home's lists down, so the quest picker's
Menu(position: fixed, no height cap) could open with its lower items below the screen edge. Reaching them meant scrolling the page — which moves the trigger, so the menu follows and is never stable/clickable (reproduced locally with--repeat-each=3).Menu.sveltenow caps the popover at the room on its side (max-height, scrolls inside,overscroll-behavior: contain) and opens on the side with more room. Short menus behave exactly as before.e2e races
toBeHidden().Test plan
bun run check(0/0),bun run test(471 pass),bun run lintbun run test:e2e98 passed,bun run test:e2e:mobile49 passedhome overdue plan palette --repeat-each=3: the menu failures are gone🤖 Generated with Claude Code