Skip to content

Fix main CI: long menus stay inside the viewport; two e2e races - #28

Merged
antonsxh merged 1 commit into
mainfrom
fix-menu-overflow
Nov 22, 2026
Merged

antonsxh merged 1 commit into
mainfrom
fix-menu-overflow

Conversation

@antonsxh

Copy link
Copy Markdown
Owner

Main's CI after #27 failed in home.spec.ts (time blocks). Investigating it surfaced a real UI bug plus two test races.

Menu ran past the viewport (UI bug)

The new Overdue card pushes Home's lists down, so the quest picker's Menu (position: fixed, no height cap) could open with its lower items below the screen edge. Reaching them meant scrolling the page — which moves the trigger, so the menu follows and is never stable/clickable (reproduced locally with --repeat-each=3).

Menu.svelte now caps the popover at the room on its side (max-height, scrolls inside, overscroll-behavior: contain) and opens on the side with more room. Short menus behave exactly as before.

e2e races

  • time blocks: after Save the test clicked the block again while the edit sheet still played its exit animation (the native modal is open until it ends), so the click hit the closing dialog → it now waits for toBeHidden().
  • hideDone + quest filter: with many quests the open filter list covers the Other column's eye → the test closes it with Escape first.

Test plan

  • bun run check (0/0), bun run test (471 pass), bun run lint
  • bun run test:e2e 98 passed, bun run test:e2e:mobile 49 passed
  • home overdue plan palette --repeat-each=3: the menu failures are gone

🤖 Generated with Claude Code

The Overdue card pushes Home's lists down, so the quest picker's menu
(position: fixed, no height cap) could run past the bottom of the
viewport. Its lower items were then only reachable by scrolling the
page, which moves the trigger and the menu with it, so they could never
be clicked. Menu now caps itself at the room on its side, opens on the
side with more room and scrolls inside.

e2e: the time-block test waits for the edit sheet's exit animation
before clicking the block again (the click landed on the closing modal
in main's CI run); the hideDone test closes the quest filter before
clicking the eye it can cover when many quests exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@antonsxh
antonsxh merged commit eae8950 into main Nov 22, 2026
6 checks passed
@antonsxh
antonsxh deleted the fix-menu-overflow branch November 22, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant