Conversation
…nstances 2.8.5 is from 2018 and carries CVE-2022-25647 (deserialization DoS, fixed in 2.8.9). The managed version moves to the current release; no module overrides it. Usage is plain parsing and serialization, and the whole suite passes unchanged. The instance API `new JsonParser().parse(reader)` has been deprecated since 2.8.6 in favour of the static `JsonParser.parseReader`; the eight call sites in core and metadata move over, which is a rename, not a behaviour change — the round-trip and metadata tests cover them. Closes #19 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pom.xmlpinned Gson 2.8.5 (2018), which carries CVE-2022-25647 (deserialization DoS, fixed in 2.8.9). The single managed version moves to the current 2.14.0; no module overrides it. Usage acrosscore,metadata,agentandweb-uiis plain parsing and serialization — nothing reflective on JDK internals, which is where Gson ≥ 2.10 got stricter — and the whole suite passes unchanged on the bump alone.Since the bump makes
new JsonParser().parse(reader)(deprecated since 2.8.6) visible, the eight call sites inArchiveStoryPackReaderandDatabaseMetadataServicemove to the staticJsonParser.parseReader(...). A rename, not a behaviour change; thecoreround-trip tests and the metadata tests cover every one of them.agentshades Gson into its jar-with-dependencies; it now ships 2.14.0 too.Locally:
mvn -B -Dskip.installnodeyarn=true -Dskip.yarn=true test→ 330 run, 0 failures (39 FAT32 opt-in skips).git diff --exit-codeclean.Tracked in lgnap#19, extracted from #3.
🤖 Generated with Claude Code