Skip to content

Fix underline and half-bright being discarded where plain char is unsigned #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kay-ws wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix underline and half-bright being discarded where plain char is unsigned #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/vterm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,11 @@ class VTerm {

static CharAttr default_char_attr;
u8 cur_fcolor, cur_bcolor;
s8 cur_underline_color, cur_halfbright_color;
// Not s8: that typedef resolves to plain char, whose signedness is
// implementation-defined. On targets where char is unsigned (ARM,
// AArch64, PowerPC, s390x) the -1 sentinel below reads back as 255 and
// every `!= -1` guard in normal_char_attr() fires unconditionally.
s16 cur_underline_color, cur_halfbright_color;
ScreenBufferType active_buffer = Primary;

// action parameters
Expand Down