deps: floor js-yaml (npm) - #500
Open
jason-anthropic wants to merge 1 commit into
Open
Conversation
jason-anthropic
marked this pull request as ready for review
August 28, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floor js-yaml to 4.3.1 via a root
overridesentry in package.json (fixes CVE-2026-53550, CVE-2026-59869 / GHSA-5p4m-2wfm-xmqj).Registry provenance: this repository's lockfile is public-registry-routed by convention (its own installs fetch from public npm), so the 1 new/changed tarball URL(s) in this PR are spelled on that same public host like the rest of the file. They were resolved through Anthropic's Dependant-gated Artifactory proxy at regeneration time (the environment that regenerated the lock can only resolve through that proxy), and every genuinely new (package, version) was re-verified as servable from the gated route with matching integrity — the public URLs point at byte-identical tarballs. No Artifactory hostname is introduced into this public-convention lock.
Breakage risk: low — js-yaml is a dev-only transitive pulled in solely by eslint (
@eslint/eslintrc, declared range^4.1.0), not a runtime dependency; this is a minor move within major 4 (4.1.1 → 4.3.1) with no first-party call sites, so nothing in the shipped package is affected.overrides)The only consumer's range (
^4.1.0) already admits the floor, so the override is for durability — it prevents a future unrelated lock regen from floating the dev transitive back down below the fix.npm lsconfirmsjs-yaml@4.3.1 overridden. The regenerated lock moves only the js-yaml stanza (argparse and all other packages unchanged); the new tarball URL is spelled on registry.npmjs.org to match this lock's convention, and integrity pins the exact bytes.Verification:
npm install --package-lock-only --ignore-scripts— exit 0 (only js-yaml stanza changed).npm ls js-yaml --package-lock-only --all— exit 0 (js-yaml@4.3.1 overridden, no invalid entries).npm ci— exit 1, blocked by a pre-existing mirror gap: the internal registry returns 404 foreslint-config-prettier@8.10.2, a version already pinned by the base lock and unrelated to js-yaml. build/typecheck/runtime_probe could not run for the same reason (no node_modules); the js-yaml@4.3.1 tarball itself fetches 200.Residuals (pre-existing, not changed by this PR):
npm_cicannot complete on the BASE tree either (npm error 404 Not Found - GET https://artifactory.infra.ant.dev/artifactory/api/npm/npm-all/eslint-config-prettier/-/eslint-config-prettier-) — pre-existing and unrelated to this change; install proof is inconclusiveAutomated dependency-vulnerability floor (Versant); every verification step above was executed, not inferred.