fix(linux): skip creating host stubs for non-existent deny paths - #495
Open
gwatkins-arista wants to merge 1 commit into
Open
fix(linux): skip creating host stubs for non-existent deny paths#495gwatkins-arista wants to merge 1 commit into
gwatkins-arista wants to merge 1 commit into
Conversation
When a deny path does not exist on disk, bwrap cannot bind-mount over it without creating an empty stub file on the host. These empty files pollute working directories with 0-byte ghost dotfiles (.bashrc, .zprofile, .mcp.json, etc.) and cause race conditions (Permission denied) when multiple sandboxed commands execute concurrently. 1. In linuxGetMandatoryDenyPaths, only add dangerous files and directories in CWD if they actually exist on disk. 2. In generateFilesystemArgs, skip --ro-bind /dev/null for non-existent leaf deny paths instead of mounting over created host stub files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a deny path does not exist on disk, bwrap cannot bind-mount over it without creating an empty stub file on the host. These empty files pollute working directories with 0-byte ghost dotfiles (.bashrc, .zprofile, .mcp.json, etc.) and cause race conditions (Permission denied) when multiple sandboxed commands execute concurrently.