deps: floor brace-expansion (npm) - #488
Open
jason-anthropic wants to merge 1 commit into
Open
Conversation
jason-anthropic
marked this pull request as ready for review
August 22, 2026 06:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floor brace-expansion to 1.1.18 (major 1) and 2.1.4 (major 2) via scoped npm overrides in the root package.json (fixes CVE-2026-13149, CVE-2026-14257, CVE-2026-69152).
Registry provenance: this repository's lockfile is public-registry-routed by convention (its own installs fetch from public npm), so the 2 new/changed tarball URL(s) in this PR are spelled on that same public host like the rest of the file. They were resolved through Anthropic's Dependant-gated Artifactory proxy at regeneration time (the environment that regenerated the lock can only resolve through that proxy), and every genuinely new (package, version) was re-verified as servable from the gated route with matching integrity — the public URLs point at byte-identical tarballs. No Artifactory hostname is introduced into this public-convention lock.
Breakage risk: low — brace-expansion is a dev-only transitive on both major lines (pulled in by eslint-plugin-import→minimatch@3 and typescript-eslint→minimatch@9); it is not a shipped runtime dependency, and both moves stay within their own major (1.1.13→1.1.18 patch, 2.0.3→2.1.4 minor), so no consumer is forced across a major and no first-party call site touches the changed surface.
Each major is floored with its own
overrideskey (brace-expansion@1,brace-expansion@2) so neither minimatch consumer is moved across a major. The lockfile regen touched only the two brace-expansion stanzas; new tarball URLs are spelled on registry.npmjs.org to match this lock's existing convention (integrity hashes pin the exact bytes).Verification:
npm install --package-lock-only— exit 0; only the two brace-expansion entries changed.npm ls brace-expansion --all --package-lock-only— exit 0; both resolve asoverriddenat 1.1.18 and 2.1.4, no invalid edges.npm ci --ignore-scripts— exit 1, pre-existing and unrelated: an unrelated dev dep (eslint-config-prettier@8.10.2) is missing from the gated proxy and fails identically at base. The two brace-expansion floor tarballs were independently confirmed fetchable.Notes: build/typecheck/runtime probe could not run because node_modules cannot be materialized while the unrelated frozen-install failure above persists; this change touches only dev transitive version floors.
Residuals (pre-existing, not changed by this PR):
npm_cicannot complete on the BASE tree either (npm error 404 Not Found - GET https://artifactory.infra.ant.dev/artifactory/api/npm/npm-all/eslint-config-prettier/-/eslint-config-prettier-) — pre-existing and unrelated to this change; install proof is inconclusiveAutomated dependency-vulnerability floor (Versant); every verification step above was executed, not inferred.