fix(macOS): authenticate Git SSH SOCKS proxy connections - #482
Open
Kaylebor wants to merge 1 commit into
Open
Conversation
Author
|
Reasoning/testing: I've been playing with copying Codex's auto-review flow on Pi (more or less), here https://github.com/Kaylebor/pi-permission-reviewer Heavily vibe-coded though, not really tested on serious work yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS's bundled BSD
ncsupports SOCKS5 but cannot perform username/password authentication. When the sandbox proxy requires its per-session credential, Git SSH fails during SOCKS method negotiation before reaching the repository.This adds a small Node-based
ProxyCommandclient that is selected only on macOS whenproxyAuthTokenis present. It performs the standard SOCKS5 username/password handshake, connects to the requested SSH destination, and pipes the SSH stream through. Unauthenticated macOS configurations retain the existing BSDnccommand, and Linux behavior is unchanged.The SOCKS server is intentionally untouched. This keeps the change on the client side and avoids the broader server rewrite and hardening scope in #385, which provided the relevant inspiration for the authentication problem.
Testing
npm run typechecknpm run buildnpm run lint:checkbun test test/sandbox/proxy-env-vars.test.ts test/sandbox/socks-authenticated-client.test.ts