Skip to content

fix(transport): catch all TimeoutError variants in process termination escalation loop #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Echolonius wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(transport): catch all TimeoutError variants in process termination escalation loop #1155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/claude_agent_sdk/_internal/transport/subprocess_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,14 +891,14 @@ async def close(self) -> None:
try:
with anyio.fail_after(5):
await self._process.wait()
except TimeoutError:
except (TimeoutError, getattr(anyio, "TimeoutError", TimeoutError)):
# Graceful shutdown timed out — force terminate
with suppress(ProcessLookupError):
self._process.terminate()
try:
with anyio.fail_after(5):
await self._process.wait()
except TimeoutError:
except (TimeoutError, getattr(anyio, "TimeoutError", TimeoutError)):
# SIGTERM handler blocked — force kill (SIGKILL)
with suppress(ProcessLookupError):
self._process.kill()
Expand Down