You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[claude code] Thank you for the PR. We are closing this one and keeping the reservation.
The __buffa and __Buffa prefixes are documented as reserved for the derive output (the "Reserved identifiers" section of the buffa-remote-derive crate docs), so a user lifetime named __buffa_de is outside what the derives support. This PR makes two of the generated names collision-proof (the __buffa_de and __buffa_arb lifetimes). The __buffa_iter lifetime and the generated type parameters (__BuffaIter, __BuffaSerializer, __BuffaDeserializer, __BuffaValue, __BuffaError, __BuffaVisitor) would still collide, and the docs section would then forbid something that partly works. The defect a user can hit without touching the reserved prefix, the unprefixed value bindings from #652, is fixed by #693.
The token scan itself is sound. Lifting the reservation entirely would mean covering every generated lifetime and type parameter plus the docs section; if you want to pursue that, please open an issue first so we can settle whether the reservation should go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Implementation