Skip to content

Multiple Versions page shows incorrect 'npm-registry dedupe' command #213

Description

@MichielTondeur

Describe the bug

The Multiple Versions page shows an alert informing the user of a dedupe command they could run.

However, when generating a report for a package via the browser, the package manager is not known ahead of time.

This causes the command to reference npm-registry dedupe, where npm-registry is an internal value instead of an actual runnable command.

Should this message be shown when we don't know the package manager of the user?

Image

Reproduction

https://node-modules.dev/report/multiple-versions#install=eslint

System Info

Browsers:
    Chrome: 152.0.7977.75
    Firefox: 156.0.1
    Firefox Developer Edition: 156.0.1

Used Package Manager

npm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions