You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hides the Ctrl+B backgrounding hint when every running shell or subagent was launched with background: true. The hint remains visible when at least one foreground shell or subagent can still be moved to the background.
The refreshed implementation keeps the current v2 delayed-presence behavior and canonical tool-name matching. Focused coverage includes foreground-only, background-only, mixed, and unrelated running tools.
How did you verify your code works?
cd packages/tui && bun test --timeout 30000 --only-failures — 631 pass, 5 skip
cd packages/tui && bun run typecheck
bun run typecheck — 33/33 package tasks passed
bun run lint packages/tui/src/routes/session/index.tsx packages/tui/test/cli/tui/background-tool-hint.test.ts — 0 errors
Screenshots / recordings
Not included: this only suppresses an inapplicable hint; it does not change the hint styling or layout.
Closes #36940 is present in the required issue section. This PR targets v2 because BackgroundToolHint does not exist in this form on dev; GitHub therefore leaves closingIssuesReferences empty for the non-default base branch, which triggers needs:issue. Could a maintainer confirm the v2 target and clear the label?
Following up once now that #37306 has merged: that PR explicitly leaves async-only hint suppression to #37088, and the current v2 branch still shows BackgroundToolHint for any running shell/subagent without excluding input.background === true. The issue is labeled 2.0, this branch remains mergeable with v2, and the focused regressions cover foreground-only, background-only, mixed, and unrelated running tools.
The needs:issue label also appears to be a workflow false positive: the PR description contains Closes #36940, but GitHub leaves closingIssuesReferences empty for this non-default v2 base, while pr-standards.yml relies on that field. Could a maintainer please review the v2 scope and remove the label?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36940
Type of change
What does this PR do?
Hides the Ctrl+B backgrounding hint when every running shell or subagent was launched with
background: true. The hint remains visible when at least one foreground shell or subagent can still be moved to the background.The refreshed implementation keeps the current
v2delayed-presence behavior and canonical tool-name matching. Focused coverage includes foreground-only, background-only, mixed, and unrelated running tools.How did you verify your code works?
cd packages/tui && bun test --timeout 30000 --only-failures— 631 pass, 5 skipcd packages/tui && bun run typecheckbun run typecheck— 33/33 package tasks passedbun run lint packages/tui/src/routes/session/index.tsx packages/tui/test/cli/tui/background-tool-hint.test.ts— 0 errorsScreenshots / recordings
Not included: this only suppresses an inapplicable hint; it does not change the hint styling or layout.
Checklist