fix(pty): provide statx for musl builds - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libghostty-vt.a: undefined reference to 'statx'. Zig 0.16'sstd.Iocalls libcstatxand assumes every musl provides it (std.c.versionCheckreturns true for musl), but Rust 1.90's self-contained musl is 1.2.3;statxarrived in musl 1.2.5. This blocks thev0.2.0release because the release job requires every build.statxfortarget_env = "musl"as a directSYS_statxsyscall, which is what musl 1.2.5's wrapper does (return value anderrnosemantics unchanged). Other targets are unaffected.Validation
ubuntu:22.04aarch64 container withmusl-tools, Rust 1.90.0, and Zig 0.16.0 throughscript/release-bin/zig.cargo test --target aarch64-unknown-linux-musl --lib --test service --test ownershipand--test playground, the release build, and the release smoke test (play --runtime-dir ... --name smoke)./andENOENTfor a missing path.cargo fmt --checkandcargo clippy --all-targets -D warningspass foraarch64-unknown-linux-musl,x86_64-unknown-linux-musl, and macOS.Rollout
After merge, move the
v0.2.0tag to the merge commit to rerun the release.