docs(material/bottom-sheet): clarify panelClass target#33222
Open
mike-lmctl wants to merge 1 commit intoangular:mainfrom
Open
docs(material/bottom-sheet): clarify panelClass target#33222mike-lmctl wants to merge 1 commit intoangular:mainfrom
mike-lmctl wants to merge 1 commit intoangular:mainfrom
Conversation
The bottom sheet config is passed through to CDK Dialog and Overlay, where panelClass is applied to the overlay pane. Update the config comment so the generated API docs match the current behavior. Related: angular#33103 Tested: git diff --check -- src/material/bottom-sheet/bottom-sheet-config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33103.
MatBottomSheetConfig.panelClassis forwarded through CDK Dialog/Overlay, where it applies to the overlay pane. This updates the config comment so the API docs describe the current behavior instead of saying the class is added to the bottom sheet container.Tested:
git diff --check -- src/material/bottom-sheet/bottom-sheet-config.ts