test(multiple): check for incorrect usage of Angular Aria directives and log violations#33195
Open
adolgachev wants to merge 9 commits intoangular:mainfrom
Open
test(multiple): check for incorrect usage of Angular Aria directives and log violations#33195adolgachev wants to merge 9 commits intoangular:mainfrom
adolgachev wants to merge 9 commits intoangular:mainfrom
Conversation
angular-robot
Bot
added
detected: feature
adolgachev
force-pushed
the
aria-validation
branch
from
1b0bef9 to
8a745a6
Compare
adolgachev
changed the title
adolgachev
changed the title
adolgachev
force-pushed
the
aria-validation
branch
from
8a745a6 to
be06cbf
Compare
ok7sai
reviewed
May 6, 2026
ok7sai
reviewed
May 6, 2026
adolgachev
force-pushed
the
aria-validation
branch
from
249d896 to
0c9eb7b
Compare
adolgachev
force-pushed
the
aria-validation
branch
from
14258d5 to
e631419
Compare
adolgachev
force-pushed
the
aria-validation
branch
4 times, most recently
from
ea9143c to
e17912e
Compare
…es and log violations
… and log violations
…nd log violations
…nd log violations
…g element and violations
adolgachev
force-pushed
the
aria-validation
branch
from
e17912e to
15a16d9
Compare
adolgachev
added
the
target: rc
adolgachev
commented
May 7, 2026
| read: () => { | ||
| const violations: string[] = []; | ||
| if (!this._popup()) { | ||
| violations.push( |
Contributor
Author
There was a problem hiding this comment.
This is actually erroring out on the demo page, even when set up. I can investigate further possible timing issue or we could just punt it to possibly deal with it later.
Member
There was a problem hiding this comment.
Possibly due to the recent change that hides the overlay when a popup is collapsed.
adolgachev
added
the
action: review
ok7sai
approved these changes
May 8, 2026
| validate(): string[] { | ||
| const violations: string[] = []; | ||
|
|
||
| const rows = this.inputs.rows(); |
Member
There was a problem hiding this comment.
Those are probably invalid when used as a filterable table.
| validate(): string[] { | ||
| const violations: string[] = []; | ||
|
|
||
| if (this.inputs.items().length === 0) { |
Member
There was a problem hiding this comment.
Same comment. This might be invalid when used as a filterable tree.
| /** Logs each of the violations to the console as errors, optionally with the host element context. */ | ||
| export function reportViolations(violations: string[], element: Element): void { | ||
| if (violations.length) { | ||
| console.error('Violations found on element: %o:', element); |
Member
There was a problem hiding this comment.
warn is probably less aggressive give the violations don't break the build.
| tab: this._tabPattern, | ||
| }); | ||
|
|
||
| private readonly _tabContent = contentChild(TabContent); |
Member
There was a problem hiding this comment.
Should probably consolidate this into the DeferredContent and check whether a DeferredContent is missing when DeferredContentAware is used.
| read: () => { | ||
| const violations: string[] = []; | ||
| if (!this._popup()) { | ||
| violations.push( |
Member
There was a problem hiding this comment.
Possibly due to the recent change that hides the overlay when a popup is collapsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used gemini to go through all of the components and generate additional violation checks for possible issues with how each set of angular aria directives are used together. Also generated specs for the new and previously existing violations.
Final commit adds a utility method to report the violations which does the console.error but also takes in an element to help in location where the issue is coming from.