test: update NG_ALLOWED_HOSTS to include port in e2e tests#33153
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
test: update NG_ALLOWED_HOSTS to include port in e2e tests#33153clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates multiple end-to-end test files within the server-rendering suite to include the dynamic port in the NG_ALLOWED_HOSTS environment variable. By changing the value from 'localhost' to 'localhost:${port}', the tests now correctly account for the specific port assigned to the server instance. I have no feedback to provide.
alan-agius4
requested changes
May 8, 2026
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
The is not right.
The change needs to be done in @angular/ssr, I’ll take care of this on Monday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.