refactor(@angular-devkit/core): deprecate stringToFileBuffer and fileBufferToString#33150
Merged
clydin merged 1 commit intoangular:mainfrom May 8, 2026
Merged
Conversation
angular-robot
Bot
added
detected: deprecation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the stringToFileBuffer and fileBufferToString utility functions in favor of native TextEncoder and TextDecoder APIs. The changes involve updating numerous test files and builders across the repository to use these native interfaces directly. Feedback was provided regarding the createWorkspaceHost implementation, suggesting that TextEncoder and TextDecoder instances should be reused to avoid redundant allocations during file operations.
…BufferToString DEPRECATED: `stringToFileBuffer` and `fileBufferToString` are deprecated. Use standard Web APIs (`TextEncoder` and `TextDecoder`) instead. Internal usages within the repository have been removed and replaced with standard Web APIs. The public API golden file for `@angular-devkit/core` has been updated to reflect the deprecations.
clydin
force-pushed
the
refactor/deprecate-buffer-helpers
branch
from
747a281 to
0ae5a9c
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
May 8, 2026
alan-agius4
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPRECATED:
stringToFileBufferandfileBufferToStringare deprecated. Use standard Web APIs (TextEncoderandTextDecoder) instead.Internal usages within the repository have been removed and replaced with standard Web APIs. The public API golden file for
@angular-devkit/corehas been updated to reflect the deprecations.