Skip to content

Remove BuildConfig from release artifacts #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anggrayudi merged 3 commits into from
Aug 20, 2025
Merged

Remove BuildConfig from release artifacts #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25e2605
Remove BuildConfig from release artifacts
machiav3lli Jul 7, 2025
3eb81dc
Remove: BuildConfig from debug artifacts (assurance for parity of deb…
machiav3lli Jul 15, 2025
3181c66
Remove: BuildConfig usage
machiav3lli Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions storage/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,8 @@ dependencies {
testImplementation(libs.powermock.junit4)
testImplementation(libs.powermock.api.mockito)
}

afterEvaluate {
tasks.findByName("generateReleaseBuildConfig")?.enabled = false
tasks.findByName("generateDebugBuildConfig")?.enabled = false
}
18 changes: 9 additions & 9 deletions storage/src/main/java/com/anggrayudi/storage/SimpleStorage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,23 +657,23 @@ class SimpleStorage private constructor(private val wrapper: ComponentWrapper) {
}

companion object {

const val LIBRARY_PACKAGE_NAME = "com.anggrayudi.storage"
private const val KEY_REQUEST_CODE_STORAGE_ACCESS =
BuildConfig.LIBRARY_PACKAGE_NAME + ".requestCodeStorageAccess"
LIBRARY_PACKAGE_NAME + ".requestCodeStorageAccess"
private const val KEY_REQUEST_CODE_FOLDER_PICKER =
BuildConfig.LIBRARY_PACKAGE_NAME + ".requestCodeFolderPicker"
LIBRARY_PACKAGE_NAME + ".requestCodeFolderPicker"
private const val KEY_REQUEST_CODE_FILE_PICKER =
BuildConfig.LIBRARY_PACKAGE_NAME + ".requestCodeFilePicker"
LIBRARY_PACKAGE_NAME + ".requestCodeFilePicker"
private const val KEY_REQUEST_CODE_CREATE_FILE =
BuildConfig.LIBRARY_PACKAGE_NAME + ".requestCodeCreateFile"
LIBRARY_PACKAGE_NAME + ".requestCodeCreateFile"
private const val KEY_REQUEST_CODE_FRAGMENT_PICKER =
BuildConfig.LIBRARY_PACKAGE_NAME + ".requestCodeFragmentPicker"
LIBRARY_PACKAGE_NAME + ".requestCodeFragmentPicker"
private const val KEY_EXPECTED_STORAGE_TYPE_FOR_ACCESS_REQUEST =
BuildConfig.LIBRARY_PACKAGE_NAME + ".expectedStorageTypeForAccessRequest"
LIBRARY_PACKAGE_NAME + ".expectedStorageTypeForAccessRequest"
private const val KEY_EXPECTED_BASE_PATH_FOR_ACCESS_REQUEST =
BuildConfig.LIBRARY_PACKAGE_NAME + ".expectedBasePathForAccessRequest"
LIBRARY_PACKAGE_NAME + ".expectedBasePathForAccessRequest"
private const val KEY_LAST_VISITED_FOLDER =
BuildConfig.LIBRARY_PACKAGE_NAME + ".lastVisitedFolder"
LIBRARY_PACKAGE_NAME + ".lastVisitedFolder"
private const val TAG = "SimpleStorage"

private const val DEFAULT_REQUEST_CODE_STORAGE_ACCESS: Int = 1
Expand Down
7 changes: 4 additions & 3 deletions storage/src/main/java/com/anggrayudi/storage/SimpleStorageHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import androidx.activity.ComponentActivity
import androidx.appcompat.app.AlertDialog
import androidx.documentfile.provider.DocumentFile
import androidx.fragment.app.Fragment
import com.anggrayudi.storage.SimpleStorage.Companion.LIBRARY_PACKAGE_NAME
import com.anggrayudi.storage.callback.CreateFileCallback
import com.anggrayudi.storage.callback.FilePickerCallback
import com.anggrayudi.storage.callback.FileReceiverCallback
Expand Down Expand Up @@ -452,10 +453,10 @@ class SimpleStorageHelper {
const val TYPE_FOLDER_PICKER = 2

private const val KEY_OPEN_FOLDER_PICKER_ONCE_GRANTED =
BuildConfig.LIBRARY_PACKAGE_NAME + ".pickerToOpenOnceGranted"
LIBRARY_PACKAGE_NAME + ".pickerToOpenOnceGranted"
private const val KEY_ORIGINAL_REQUEST_CODE =
BuildConfig.LIBRARY_PACKAGE_NAME + ".originalRequestCode"
private const val KEY_FILTER_MIME_TYPES = BuildConfig.LIBRARY_PACKAGE_NAME + ".filterMimeTypes"
LIBRARY_PACKAGE_NAME + ".originalRequestCode"
private const val KEY_FILTER_MIME_TYPES = LIBRARY_PACKAGE_NAME + ".filterMimeTypes"

@JvmStatic
fun redirectToSystemSettings(context: Context) {
Expand Down
3 changes: 2 additions & 1 deletion storage/src/test/java/com/anggrayudi/storage/SimpleStorageTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.content.Context
import android.content.UriPermission
import android.net.Uri
import android.os.Build
import com.anggrayudi.storage.SimpleStorage.Companion.LIBRARY_PACKAGE_NAME
import io.mockk.*
import java.io.File
import kotlin.concurrent.thread
Expand All @@ -25,7 +26,7 @@ class SimpleStorageTest {

private val context =
mockk<Context> {
val dataDirectoryPath = "/data/user/0/${BuildConfig.LIBRARY_PACKAGE_NAME}"
val dataDirectoryPath = "/data/user/0/${LIBRARY_PACKAGE_NAME}"
val fileDir = File("$dataDirectoryPath/files")
every { filesDir } returns fileDir
every { dataDir } returns File(dataDirectoryPath)
Expand Down
4 changes: 2 additions & 2 deletions storage/src/test/java/com/anggrayudi/storage/file/DocumentFileCompatTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package com.anggrayudi.storage.file

import android.content.Context
import android.os.Environment
import com.anggrayudi.storage.BuildConfig
import com.anggrayudi.storage.SimpleStorage.Companion.LIBRARY_PACKAGE_NAME
import com.anggrayudi.storage.file.StorageId.PRIMARY
import io.mockk.every
import io.mockk.mockk
Expand All @@ -21,7 +21,7 @@ class DocumentFileCompatTest {

private val context =
mockk<Context> {
val dataDirectoryPath = "/data/user/0/${BuildConfig.LIBRARY_PACKAGE_NAME}"
val dataDirectoryPath = "/data/user/0/${LIBRARY_PACKAGE_NAME}"
val fileDir = File("$dataDirectoryPath/files")
every { filesDir } returns fileDir
every { dataDir } returns File(dataDirectoryPath)
Expand Down