Repository navigation
Conversation
PR #13 — fix round oneChanges
EvidenceAll commands used .venv/bin/python -m pytest -q tests/unit/test_route_caller_choice.py tests/unit/test_open_factory_route.py tests/unit/test_seat_alias_effort.py tests/unit/test_install_policy_models.py tests/integration/test_route_pick_leases.py tests/integration/test_route_reservations.py tests/integration/test_codex_seat_home.pyResult: 25 passed in 27.42s, exit 0. Receipt: .venv/bin/ruff check clients/route config/coding-agents/*.pyResult: All checks passed!, exit 0 ( Factory-runtime durability advisoryConfirmed using
Consequently, the cx-bg patch and install-policy's file swap can be reverted by HandoffProposed fix commit message: Author vendor: OpenAI (Codex Sol). Fresh cross-vendor review remains for the |
Review fix round for PR #13: route pick no longer writes a route_pick_leases_unknown ledger row when the lease lookup is unavailable (one stderr diagnostic instead), pick_leases honors fixture mode so fixture tests never read live reservations, two fixture-isolation regression tests, and the E501 lines wrapped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review fix round for PR #13: route pick no longer writes a route_pick_leases_unknown ledger row when the lease lookup is unavailable (one stderr diagnostic instead), pick_leases honors fixture mode so fixture tests never read live reservations, two fixture-isolation regression tests, and the E501 lines wrapped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1474ed3 to
cdd7189
Compare
|
Landed on main as 31dba9b + cdd7189 (rebased onto bc6c6f8; closed by push). Re-review PASS at 1474ed3 (Sonnet verifier, author vendor openai; the Fable trailer is the committer, Codex wrote the fix). Deployed: install-policy.py run, cx-bg patch applied to the current factory-runtime release (backup .bak-pre-cdd71896); durable cx-bg fix goes to agent-rails factory-runtime. 🤖 Generated with Claude Code |
Summary
Proof
All tests used env -u RAILS_CHECK_HOST and isolated HOME/data under /tmp.
Boundaries
No credentials read, no agent messages, no deployment, no restart. Cross-vendor review not run because the task forbids agent messages. Chromium Mach bootstrap SIGTRAP and live websocket/latency behavior remain source-reported/unverified; the settings and layout are proven, not runtime recovery. The original pick-only oracle was updated because it contradicted the explicitly requested new reservation-aware pick contract; admission/expiry/heartbeat checks are retained.
Deployment after merge
From the merged main checkout on each seat-launching machine:
Installer copies route, table, definitions and codex-seat-home.py to the managed destinations. No app runtime code changed, so lb-restart is not needed. Relaunch affected seats to pick up their new definition/home. Do not force a drifted launcher patch.
🤖 Generated with Claude Code
Author: Codex (Sol); committed by the orchestrator because the Codex sandbox cannot write the worktree git dir.
🤖 Generated with Claude Code