Skip to content

Fix installer Linux audio dependencies - #6

Merged
andy5090 merged 1 commit into
mainfrom
agent/install-linux-audio-dependencies
Aug 12, 2026
Merged

Fix installer Linux audio dependencies#6
andy5090 merged 1 commit into
mainfrom
agent/install-linux-audio-dependencies

Conversation

@andy5090

Copy link
Copy Markdown
Owner

What changed

  • Detect missing ALSA runtime packages on Debian and Ubuntu during installation.
  • Install libasound2 and libasound2-plugins through apt-get when needed.
  • Document the WSLg PulseAudio requirement and complete source-build dependencies.

Why

Termleaf uses Rodio/CPAL's ALSA backend on Linux. WSLg exposes its Windows audio
route through PulseAudio, but a minimal Ubuntu installation may not include the
ALSA PulseAudio plugin. In that case Termleaf cannot open a default output stream
and runs silently.

The installer now supplies the missing runtime dependency instead of leaving the
application installed without working audio.

Validation

  • sh -n termleaf-installer.sh
  • git diff --check
  • cargo test --locked (84 passed, 1 hardware test ignored)
  • cargo test --locked audio::tests::hardware_audio_callback_stays_alive -- --ignored --nocapture
  • WSLg playback of assets/typewriter-return.wav with aplay

@andy5090
andy5090 marked this pull request as ready for review August 12, 2026 11:46
@andy5090
andy5090 merged commit 0ff7124 into main Aug 12, 2026
1 check passed
@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@andy5090
andy5090 deleted the agent/install-linux-audio-dependencies branch August 12, 2026 11:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1daa59133

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread termleaf-installer.sh
fi

missing_packages=""
for package_name in libasound2 libasound2-plugins; do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install libasound2t64 on Ubuntu 24.04

On a minimal Ubuntu 24.04 (Noble) installation—the WSLg scenario this change targets—libasound2 is a virtual package rather than an installable package. I checked apt-get install --simulate --yes libasound2 on Noble, which reports that it is provided by libasound2t64 and then fails with Package 'libasound2' has no installation candidate. Consequently, when ALSA is absent, the new dependency step exits under set -e before Termleaf is downloaded; detect/install libasound2t64 on systems where that is the concrete package, or otherwise resolve the available provider.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant