Skip to content

Move Gradle plugin from build-logic/ to repo root#215

Merged
kirich1409 merged 1 commit into
developfrom
refactor/move-plugin-to-root
May 21, 2026
Merged

Move Gradle plugin from build-logic/ to repo root#215
kirich1409 merged 1 commit into
developfrom
refactor/move-plugin-to-root

Conversation

@kirich1409
Copy link
Copy Markdown
Contributor

Summary

  • The published Gradle plugin (dev.androidbroadcast.featured) lived in build-logic/featured-gradle-plugin/ while a stale empty featured-gradle-plugin/ directory sat at the repo root — confusing layout from a partial earlier refactor.
  • build-logic/ is the conventional location for internal convention plugins, not for a Maven-Central artifact. Standard OSS Gradle-plugin repos (Detekt, OkHttp, Ktlint, …) keep the published plugin in its own directory and reserve build-logic/ for build-internal logic.
  • This PR consolidates the plugin into featured-gradle-plugin/ as an included build at the repo root and removes the now-redundant build-logic/ wrapper.

What changed

  • git mv of all 78 plugin sources/tests/fixtures from build-logic/featured-gradle-plugin/ to featured-gradle-plugin/.
  • Merged build-logic/settings.gradle.kts into featured-gradle-plugin/settings.gradle.kts (now a standalone included-build root: rootProject.name = "featured-gradle-plugin", no nested include(...)).
  • Root settings.gradle.kts: includeBuild("build-logic")includeBuild("featured-gradle-plugin").
  • Root build.gradle.kts: gradle.includedBuild("build-logic").task(":featured-gradle-plugin:publishTo…")gradle.includedBuild("featured-gradle-plugin").task(":publishTo…") for both publishToMavenCentral and publishToMavenLocal.
  • Removed empty build-logic/.
  • Rewrote root CLAUDE.md to reflect the new layout (and to actually document architecture/commands — prior content was minimal).

No functional change: the plugin is still consumed via includeBuild(...) for dogfooding on :sample:feature-*, the publication coordinates are unchanged, and no production sources were touched.

Test plan

  • ./gradlew :featured-gradle-plugin:compileKotlin — green
  • ./gradlew :featured-gradle-plugin:test — 266 tests green
  • ./gradlew :core:assemble, :sample:android-app:assemble (and other key modules) — green
  • ./gradlew spotlessCheck — green
  • CI: full pipeline (incl. K/N iOS framework linking, which hit OOM locally on this machine — unrelated to the move)

🤖 Generated with Claude Code

build-logic/ is the conventional location for internal convention plugins,
not a published Maven Central artifact. Moves the plugin to its own
included build at featured-gradle-plugin/ (the previously empty directory),
matching the standard OSS Gradle plugin layout. Dogfooding on
:sample:feature-* remains via includeBuild(...) — no functional change.

Removes the empty build-logic/ wrapper. Updates root settings.gradle.kts,
build.gradle.kts and CLAUDE.md to reflect the new structure.
@kirich1409 kirich1409 marked this pull request as ready for review May 21, 2026 16:04
Copilot AI review requested due to automatic review settings May 21, 2026 16:04
@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@kirich1409 kirich1409 merged commit 5ba03d7 into develop May 21, 2026
9 checks passed
@kirich1409 kirich1409 deleted the refactor/move-plugin-to-root branch May 21, 2026 16:05
@kirich1409 kirich1409 review requested due to automatic review settings May 21, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant