Skip to content

Updated Dependencies for compose 1.11.1#911

Draft
raystatic wants to merge 1 commit into
mainfrom
rr/snippet-update-2026-05-08
Draft

Updated Dependencies for compose 1.11.1#911
raystatic wants to merge 1 commit into
mainfrom
rr/snippet-update-2026-05-08

Conversation

@raystatic
Copy link
Copy Markdown
Contributor

Updated dependencies

@raystatic raystatic requested review from a team, kkuan2011 and yrezgui as code owners May 9, 2026 22:11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates hardcoded compileSdk and targetSdk versions across multiple modules to use the central version catalog and updates several library dependencies, including Compose, Paging, and Wear components. Feedback was provided regarding the use of .toInt() for SDK versions, which could cause issues if a non-integer preview SDK string is used in the version catalog.

Comment thread telecom/build.gradle.kts
compileSdk {
version = release(37)
}
compileSdk = libs.versions.compileSdk.get().toInt()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The replacement of the compileSdk block with a direct assignment using .toInt() might lead to issues if the version catalog value is ever changed to a non-integer string (e.g., for a preview SDK like 'android-38'). While it works for the current value '37', consider using a more flexible approach if preview SDK support is required, as the previous release(37) helper likely handled this abstraction.

@raystatic raystatic marked this pull request as draft May 10, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant