Added snippets for compose test onRootWithViewInteraction API.#899
Added snippets for compose test onRootWithViewInteraction API.#899hiichoudhary wants to merge 7 commits into
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Code Review
This pull request introduces documentation snippets for the onRootWithViewInteraction API, which allows Compose tests to be scoped within Espresso ViewInteraction objects. It also updates the Compose test dependencies to a newer alpha version and adds the Espresso contrib library. The review feedback points out a missing import for the onNode extension function that will cause compilation errors and highlights that several helper definitions are located outside the documentation snippet tags, which would result in incomplete and non-compilable examples for readers.
…oudhary/onRootWithViewInteraction-test-api
…ps://github.com/android/snippets into hiichoudhary/onRootWithViewInteraction-test-api
kkuan2011
left a comment
There was a problem hiding this comment.
One question on the compose version, and the rest of the code looks good.
I think the build is still failing though. You may need to apply Locale changes that Meghan made here? https://github.com/android/snippets/pull/887/changes#diff-1beda6f9b3381ed067a83333c654ea0f802ade14d49be29abf1ea1ffca3720a9 Or check when she will submit?
…oudhary/onRootWithViewInteraction-test-api
I've made the locale changes. Could you please take a look? |
kkuan2011
left a comment
There was a problem hiding this comment.
Hi Himanshu, Actually I chatted with the Compose DevRel team and they prefer to keep compose on a stable version for the main branch in the snippets repo. So you can just keep your branch open with this alpha dependency and then we merge it into main when 1.12 is stable. Sorry I will remove approval for now, since we want to hold off merging it into main for the time being.
No description provided.